We get about 25% performance gain

with the custom lsoda call, avoiding repeated getNativeSymbolInfo calls.
It's just that we should not be calling foreign functions from different
packages, because the may change without notice. Using
getNativeSymbolInfo for "call_lsoda" avoids the CRAN note, and a similar
call could probably be used for "unlock_solver", avoiding the NOTE in
checks for cran, but we should not do this in a CRAN package.

1 files changed, 89 insertions, 2 deletions

diff --git a/vignettes/web_only/benchmarks.html b/vignettes/web_only/benchmarks.html
index 5f81f39f..5376c1f5 100644
--- a/vignettes/web_only/benchmarks.html
+++ b/vignettes/web_only/benchmarks.html
@@ -1599,7 +1599,7 @@ div.tocify {
 
 <h1 class="title toc-ignore">Benchmark timings for mkin</h1>
 <h4 class="author">Johannes Ranke</h4>
-<h4 class="date">Last change 14 July 2022 (rebuilt 2022-07-14)</h4>
+<h4 class="date">Last change 14 July 2022 (rebuilt 2022-11-15)</h4>
 
 </div>
 
@@ -1635,7 +1635,7 @@ FOMC_SFO &lt;- mkinmod(
   parent = mkinsub(&quot;FOMC&quot;, &quot;m1&quot;),
   m1 = mkinsub(&quot;SFO&quot;))
 DFOP_SFO &lt;- mkinmod(
-  parent = mkinsub(&quot;FOMC&quot;, &quot;m1&quot;),
+  parent = mkinsub(&quot;FOMC&quot;, &quot;m1&quot;), # erroneously used FOMC twice, not fixed for consistency
   m1 = mkinsub(&quot;SFO&quot;))
 t3 &lt;- system.time(mmkin_bench(list(SFO_SFO, FOMC_SFO, DFOP_SFO), list(FOCUS_D)))[[&quot;elapsed&quot;]]
 t4 &lt;- system.time(mmkin_bench(list(SFO_SFO, FOMC_SFO, DFOP_SFO), list(FOCUS_D),
@@ -1816,6 +1816,30 @@ t11 &lt;- system.time(mmkin_bench(list(m_synth_DFOP_par), list(DFOP_par_c),
 <td align="right">1.770</td>
 <td align="right">3.377</td>
 </tr>
+<tr class="odd">
+<td align="left">Linux</td>
+<td align="left">Ryzen 7 1700</td>
+<td align="left">4.2.1</td>
+<td align="left">1.1.2</td>
+<td align="right">1.957</td>
+<td align="right">3.633</td>
+</tr>
+<tr class="even">
+<td align="left">Linux</td>
+<td align="left">Ryzen 7 1700</td>
+<td align="left">4.2.2</td>
+<td align="left">1.2.0</td>
+<td align="right">2.129</td>
+<td align="right">3.784</td>
+</tr>
+<tr class="odd">
+<td align="left">Linux</td>
+<td align="left">Ryzen 7 1700</td>
+<td align="left">4.2.2</td>
+<td align="left">1.3.0</td>
+<td align="right">2.046</td>
+<td align="right">3.693</td>
+</tr>
 </tbody>
 </table>
 </div>
@@ -1979,6 +2003,33 @@ t11 &lt;- system.time(mmkin_bench(list(m_synth_DFOP_par), list(DFOP_par_c),
 <td align="right">5.758</td>
 <td align="right">2.558</td>
 </tr>
+<tr class="odd">
+<td align="left">Linux</td>
+<td align="left">Ryzen 7 1700</td>
+<td align="left">4.2.1</td>
+<td align="left">1.1.2</td>
+<td align="right">1.503</td>
+<td align="right">6.147</td>
+<td align="right">2.803</td>
+</tr>
+<tr class="even">
+<td align="left">Linux</td>
+<td align="left">Ryzen 7 1700</td>
+<td align="left">4.2.2</td>
+<td align="left">1.2.0</td>
+<td align="right">1.559</td>
+<td align="right">6.097</td>
+<td align="right">2.841</td>
+</tr>
+<tr class="odd">
+<td align="left">Linux</td>
+<td align="left">Ryzen 7 1700</td>
+<td align="left">4.2.2</td>
+<td align="left">1.3.0</td>
+<td align="right">1.230</td>
+<td align="right">4.333</td>
+<td align="right">2.187</td>
+</tr>
 </tbody>
 </table>
 </div>
@@ -2193,6 +2244,42 @@ t11 &lt;- system.time(mmkin_bench(list(m_synth_DFOP_par), list(DFOP_par_c),
 <td align="right">1.744</td>
 <td align="right">2.566</td>
 </tr>
+<tr class="odd">
+<td align="left">Linux</td>
+<td align="left">Ryzen 7 1700</td>
+<td align="left">4.2.1</td>
+<td align="left">1.1.2</td>
+<td align="right">0.861</td>
+<td align="right">1.295</td>
+<td align="right">1.507</td>
+<td align="right">3.102</td>
+<td align="right">1.961</td>
+<td align="right">2.852</td>
+</tr>
+<tr class="even">
+<td align="left">Linux</td>
+<td align="left">Ryzen 7 1700</td>
+<td align="left">4.2.2</td>
+<td align="left">1.2.0</td>
+<td align="right">0.911</td>
+<td align="right">1.328</td>
+<td align="right">1.519</td>
+<td align="right">2.986</td>
+<td align="right">1.957</td>
+<td align="right">2.769</td>
+</tr>
+<tr class="odd">
+<td align="left">Linux</td>
+<td align="left">Ryzen 7 1700</td>
+<td align="left">4.2.2</td>
+<td align="left">1.3.0</td>
+<td align="right">0.693</td>
+<td align="right">0.996</td>
+<td align="right">1.121</td>
+<td align="right">2.174</td>
+<td align="right">1.427</td>
+<td align="right">2.026</td>
+</tr>
 </tbody>
 </table>
 </div>