Age | Commit message (Collapse) | Author | Files | Lines |
|
Still in preparation for analytical solutions of coupled models
|
|
Preparing for symbolic solutions for more than one compound
|
|
|
|
|
|
The likelihood ratio test method is lrtest, in addition,
methods for update and residuals were added.
|
|
The confint method can do profile likelihood based confidence intervals!
|
|
|
|
in the hope that this makes plotting cross-platform also for this error
model
|
|
mkinfit objects now include an ll() function to calculate the
log-likelihood. Part of the code was refactored, hopefully making it
easier to read and maintain. IRLS is currently the default algorithm for
the error model "obs", for no particular reason. This may be subject
to change when I get around to investigate.
Slow tests are now in a separate subdirectory and will probably
only be run by my own Makefile target.
Formatting of test logs is improved.
Roundtripping error model parameters works with a precision of 10% when
we use lots of replicates in the synthetic data (see slow tests). This
is not new in this commit, but as I think it is reasonable this
closes #7.
|
|
Address winbuilder check problems, update check log, update of static docs
|
|
generated with mkin < 0.9.49.5
|
|
|
|
|
|
|
|
|
|
The new algorithm tries direct optimization of the likelihood, as well
as a three step procedure. In this way, we consistently get the
model with the highest likelihood for SFO, DFOP and HS for all 12
new test datasets.
|
|
All of them are working now and allow for comparison
Based on SFO, DFOP and HS fits to twelve test datasets, only
the combination of direct and threestep is needed to find
the lowest AIC
|
|
|
|
|
|
Static documentation rebuilt by pkgdown
|
|
- Fix the respective error in the code
- Static documentation rebuilt by pkgdown
|
|
Now we have a three stage fitting process for
nonconstant error models:
- Unweighted least squares
- Only optimize the error model
- Optimize both
Static documentation rebuilt by pkgdown
|
|
- Also make it possible to specify initial values for error model
parameters.
- Run tests
- Rebuild docs
|
|
Remove skipped tests as I do not intend to reactivate them
|
|
- Write the NEWS
- Static documentation rebuilt by pkgdown
- Adapt mkinerrmin
- Fix (hopefully all) remaining problems in mkinfit
|
|
Zero observations at time zero made fitting the two-component error
model fail. A concentration of exactly zero does not make sense anyways,
as we generally have a limit of detection
|
|
If not quiet = TRUE
|
|
- No IRLS required
- Removed optimization algorithms other than Port
- Removed the dependency on FME
- Fitting the error model 'obs' is much faster for the FOCUS_2006_D
dataset and the FOMC_SFO model (1 second versus 3.4 seconds)
- Vignettes build slower. Compiled models needs 3 minutes instead of 1.5
- For other vignettes, the trend is less clear. Some fits are faster,
even for error_model = "const". FOCUS_Z is faster (34.9 s versus
44.1 s)
- Standard errors and confidence intervals are slightly smaller
- Removed code for plotting during the fit, as I hardly ever used it
- Merged the two cost functions (using transformed and untransformed
parameters) into one log-likelihood function
|
|
|
|
|
|
Also:
- Change rounding in print.nafta
- Add dots argument to nafta()
- Use cores=1 in examples
- Restrict N in IORE model to values > 0
|
|
- Make mmkin compatible
- Return DT50 values corresponding to k0 and kmax
- Turn incompatible parameter names in parms.ini from an error to a
warning, in order to make it possible to use this argument in calls to
mmkin
|
|
|
|
Further relax two tests to pass build on Travis
|
|
with respect to accuracy and robustness.
|
|
as the absolute value is a biased estimator for the standard deviation
|
|
Clean up the code a bit
|
|
Static documentation rebuilt by pkgdown
|
|
|
|
Also improve the irls fitting of the error model and add a test
for FOCUS_2006_C where the second component of the error model is zero
|
|
Rename 'sigma_rl' to 'sigma_twocomp' as the Rocke and Lorenzato model assumes lognormal distribution for large y.
Rebuild static documentation.
|
|
|
|
that prevented the convergence message to be returned in the case of non-convergence.
|
|
For fits generated with previous version, the version numbers used for
fitting were not stored in the fit object. Therefore, the versions
used for fitting can only be shown for fits generated with mkin
containing this commit.
|
|
Static documentation except articles rebuilt by pkgdown
|
|
|
|
|
|
Also ignore test.R in the top level directory, as it is not meant to
be public
|
|
|
|
|