From d81550d0cccae824cc748de48e7fd50ea8d8033a Mon Sep 17 00:00:00 2001 From: Johannes Ranke Date: Thu, 16 Apr 2020 18:02:18 +0200 Subject: Make na.rm = FALSE the default for geomean() This makes more sense and is in line with mean() from base R. Adapt tests and update docs. --- tests/testthat/test_geomean.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests') diff --git a/tests/testthat/test_geomean.R b/tests/testthat/test_geomean.R index 0cc3416..bf298c2 100644 --- a/tests/testthat/test_geomean.R +++ b/tests/testthat/test_geomean.R @@ -4,8 +4,8 @@ context("Geometric mean calculation") test_that("The geometric mean is correctly calculated", { expect_equal(geomean(c(1, 3, 9)), 3) expect_equal(geomean(c(0, 3, 9)), 0) - expect_error(geomean(c(1, 3, NA, 9), na.rm = FALSE), "NA") + expect_equal(geomean(c(1, 3, NA, 9), na.rm = FALSE), NA) expect_equal(geomean(c(1, 3, NA, 9), na.rm = TRUE), 3) expect_error(geomean(c(1, -3, 9)), "positive") - expect_error(geomean(c(1, -3, NA, 9)), "positive") + expect_equal(geomean(c(1, -3, NA, 9)), NA) }) -- cgit v1.2.1