diff options
| author | Johannes Ranke <jranke@uni-bremen.de> | 2022-11-16 09:15:36 +0100 |
|---|---|---|
| committer | Johannes Ranke <jranke@uni-bremen.de> | 2022-11-16 09:15:36 +0100 |
| commit | 51d63256a7b3020ee11931d61b4db97b9ded02c0 (patch) | |
| tree | cb6d628211c99cb6dd1938428a18ef4dd5a997dc /log/check.log | |
| parent | 679cf716192cdfd91dfd232578cbd4e30d7eac12 (diff) | |
We get about 25% performance gain
with the custom lsoda call, avoiding repeated getNativeSymbolInfo calls.
It's just that we should not be calling foreign functions from different
packages, because the may change without notice. Using
getNativeSymbolInfo for "call_lsoda" avoids the CRAN note, and a similar
call could probably be used for "unlock_solver", avoiding the NOTE in
checks for cran, but we should not do this in a CRAN package.
Diffstat (limited to 'log/check.log')
| -rw-r--r-- | log/check.log | 23 |
1 files changed, 17 insertions, 6 deletions
diff --git a/log/check.log b/log/check.log index 3fea2ec6..e7d4d327 100644 --- a/log/check.log +++ b/log/check.log @@ -5,7 +5,7 @@ * using options ‘--no-tests --as-cran’ * checking for file ‘mkin/DESCRIPTION’ ... OK * checking extension type ... Package -* this is package ‘mkin’ version ‘1.2.0’ +* this is package ‘mkin’ version ‘1.3.0’ * package encoding: UTF-8 * checking CRAN incoming feasibility ... Note_to_CRAN_maintainers Maintainer: ‘Johannes Ranke <johannes.ranke@jrwb.de>’ @@ -37,11 +37,18 @@ Maintainer: ‘Johannes Ranke <johannes.ranke@jrwb.de>’ * checking whether the namespace can be unloaded cleanly ... OK * checking loading without being on the library search path ... OK * checking use of S3 registration ... OK -* checking dependencies in R code ... OK +* checking dependencies in R code ... NOTE +Package in Depends field not imported from: ‘deSolve’ + These packages need to be imported from (in the NAMESPACE file) + for when this namespace is loaded but not attached. * checking S3 generic/method consistency ... OK * checking replacement functions ... OK -* checking foreign function calls ... OK -* checking R code for possible problems ... [14s/14s] OK +* checking foreign function calls ... NOTE +Foreign function call to a different package: + .C("unlock_solver", ..., PACKAGE = "deSolve") +See chapter ‘System and foreign language interfaces’ in the ‘Writing R +Extensions’ manual. +* checking R code for possible problems ... [17s/17s] OK * checking Rd files ... OK * checking Rd metadata ... OK * checking Rd line widths ... OK @@ -57,7 +64,7 @@ Maintainer: ‘Johannes Ranke <johannes.ranke@jrwb.de>’ * checking data for ASCII and uncompressed saves ... OK * checking installed files from ‘inst/doc’ ... OK * checking files in ‘vignettes’ ... OK -* checking examples ... [15s/15s] OK +* checking examples ... [20s/20s] OK * checking for unstated dependencies in ‘tests’ ... OK * checking tests ... SKIPPED * checking for unstated dependencies in vignettes ... OK @@ -69,5 +76,9 @@ Maintainer: ‘Johannes Ranke <johannes.ranke@jrwb.de>’ * checking for detritus in the temp directory ... OK * DONE -Status: OK +Status: 2 NOTEs +See + ‘/home/jranke/git/mkin/mkin.Rcheck/00check.log’ +for details. + |